Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Downgrade minimum version of roslyn required to run generators #884

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 2, 2022

Build or CI related changes

Downgrade minimum version of roslyn required to run generators as it's causing some issue on macOS and Linux build servers

What is the current behavior?

Generators fails to run on some build agents due to roslyn being at v 4.1

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge November 2, 2022 19:15
@nickrandolph
Copy link
Contributor

Do we want to track this as an issue for us to clean up the additional code when all the build agents support latest roslyn?

@dr1rrb dr1rrb merged commit 22b889a into main Nov 2, 2022
@dr1rrb dr1rrb deleted the dev/dr/downRoslyn branch November 2, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants