Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ensure building delegates are static #900

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 7, 2022

GitHub Issue (If applicable): #

Refactoring

Ensure building delegates are static

What is the current behavior?

Building delegates are not flagged as static allowing invalid usage

What is the new behavior?

They are flagged as static so it's clear when we use a closure

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb merged commit 8afa9ec into main Nov 8, 2022
@dr1rrb dr1rrb deleted the dev/dr/staticBuildDelegates branch November 8, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants