New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reactive): Allow generation of VM on non UI assembly #917

Merged

dr1rrb merged 11 commits into main from dev/dr/corePresentation

Nov 17, 2022

Member

dr1rrb commented Nov 14, 2022 •

edited

closes #917

Feature

Allow generation of VM on non UI assembly

What is the current behavior?

Generated code depends on Uno / UWP / WinUI's dispatcher

What is the new behavior?

The generated code non longer depends on dispatcher

PR Checklist

Tested code with current supported SDKs
Docs have been added/updated which fit documentation template. (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
Contains NO breaking changes
Updated the Release Notes
Associated with an issue (GitHub or internal)

dr1rrb force-pushed the dev/dr/corePresentation branch from ab6be86 to bd9afe2 Compare

November 15, 2022 15:53

dr1rrb enabled auto-merge

November 16, 2022 00:05

nickrandolph reviewed

View reviewed changes

src/Directory.Build.props Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

src/Uno.Extensions.Core/IDispatcher.cs Outdated Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

src/Uno.Extensions.Core/IDispatcher.cs Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

src/Uno.Extensions.Core/Threading/FastAsyncLock.cs Outdated Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

src/Uno.Extensions.Navigation.UI/Dispatcher.cs Outdated Show resolved Hide resolved

dr1rrb added 10 commits

November 17, 2022 11:18


          test: Ensure that command parameter is invoked on bg thread


          feat: Move dispatcher resolution to the core recative project + unify…

4e8af4d

… IDispactherInternal and IDispatcher


          feat: Make sure to initialize the dispatcher even if reative UI packa…

a59fa20

…ge not loaded yet


          feat: Genearte VM in non nested classes

25ab235


          chore: [Reactive] Move presentation classes to the core project

59c8e7b


          feat(reactive): Make the generated bindable code to not rely on UI mo…

cd20651

…dule


          chore: Fix dispatcher implementation on UWP

28d8feb


          chore: Remove extensive InternalsVisisbleTo

2776e77


          chore: Add missing ref to Core generators in Playground app

b229da1


          chore: Move some usings to global

dd5bb81

dr1rrb force-pushed the dev/dr/corePresentation branch from 95cfcb9 to dd5bb81 Compare

November 17, 2022 16:19


          chore: Remove old file header from fast async sync lock

a7fcce6

This has removal has been approved by nventive

carldebilly approved these changes

View reviewed changes

Member

carldebilly left a comment

TL;JA

dr1rrb merged commit 9e77ddf into main

dr1rrb deleted the dev/dr/corePresentation branch

November 17, 2022 21:58

dr1rrb mentioned this pull request

[Reactive] Review generation of VM #846

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment