generated from unoplatform/template
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding IApplicationBuilder #926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Uno.Extensions.Templates/content/unoapp-extensions/MyExtensionsApp.UI/HostConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Uno.Extensions.Templates/content/unoapp-extensions/MyExtensionsApp.UI/HostConfiguration.cs
Outdated
Show resolved
Hide resolved
Looking good but a couple of outstanding things:
|
dansiegel
force-pushed
the
dev/ds/appbuilder
branch
2 times, most recently
from
November 18, 2022 21:00
77421fe
to
ace3c93
Compare
src/Uno.Extensions.Logging/Uno.Extensions.Logging.UWP.Skia.csproj
Outdated
Show resolved
Hide resolved
src/Uno.Extensions.Templates/content/unoapp-extensions/MyExtensionsApp.UI/HostConfiguration.cs
Show resolved
Hide resolved
dansiegel
force-pushed
the
dev/ds/appbuilder
branch
from
November 21, 2022 16:30
ace3c93
to
de6cd91
Compare
nickrandolph
approved these changes
Nov 22, 2022
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All code revolves around the IHostBuilder
What is the new behavior?
A new IApplicationBuilder has been introduced to help simplify the process of bootstrapping the application startup. Currently the ShowAsync has been moved to the template until we determine the best location for this as Toolkit Navigation doesn't actually have a reference to Hosting so it cannot access IApplicationBuilder. There is also no current way to pass the boolean for Uno logging when creating the Host.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):