Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding IApplicationBuilder #926

Merged
merged 11 commits into from
Nov 22, 2022
Merged

feat: adding IApplicationBuilder #926

merged 11 commits into from
Nov 22, 2022

Conversation

dansiegel
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

All code revolves around the IHostBuilder

What is the new behavior?

A new IApplicationBuilder has been introduced to help simplify the process of bootstrapping the application startup. Currently the ShowAsync has been moved to the template until we determine the best location for this as Toolkit Navigation doesn't actually have a reference to Hosting so it cannot access IApplicationBuilder. There is also no current way to pass the boolean for Uno logging when creating the Host.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@dansiegel dansiegel added the kind/enhancement New feature or request. label Nov 18, 2022
@nickrandolph
Copy link
Contributor

Looking good but a couple of outstanding things:

  • Need to update Logging to provide implementation of IServiceInitialize for when unologging is enabled
  • Need to alter InitializeNavigationAsync so that there's only one method and that if user calls UseToolkitNavigation, Navigation.Toolkit gets an opportunity to initialize either LoadingView or SplashScreen accordingly

@dansiegel dansiegel force-pushed the dev/ds/appbuilder branch 2 times, most recently from 77421fe to ace3c93 Compare November 18, 2022 21:00
@nickrandolph nickrandolph marked this pull request as ready for review November 22, 2022 03:15
@nickrandolph nickrandolph merged commit ae2d2db into main Nov 22, 2022
@nickrandolph nickrandolph deleted the dev/ds/appbuilder branch November 22, 2022 12:12
@welcome
Copy link

welcome bot commented Nov 22, 2022

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants