Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generic support for displaying Shell #943

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

dansiegel
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Due to the overloaded extension in Toolkit Navigation you must provide special logic to handle when the Navigation Root is a Loading View and you must provide your own implementation to handle the ShowAsync for your Shell.

When providing initialNavigate it is ignored and not passed into InternalInitializeNavigationAsync

What is the new behavior?

IApplicationBuilder has a new property Dictionary<object, object> Properties to maintain state when needed between extensions. A new extension is available to use Toolkit Navigation using the IApplicationBuilder. An extension has been added to the core Navigation library ShowAsync<TShell>.
The overload for Window.InitializeNavigationAsync in Toolkit Navigation is now obsolete and will cause an error if used with a message to use the IApplicationBuilder.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@nickrandolph nickrandolph merged commit 44b48a6 into main Nov 25, 2022
@nickrandolph nickrandolph deleted the dev/ds/appbuilder-nav branch November 25, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants