generated from unoplatform/template
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generic support for displaying Shell #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
force-pushed
the
dev/ds/appbuilder-nav
branch
from
November 23, 2022 23:13
50903dd
to
690ab07
Compare
src/Uno.Extensions.Navigation.Toolkit/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Uno.Extensions.Navigation.Toolkit/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Uno.Extensions.Templates/content/unoapp-extensions/MyExtensionsApp.UI/App.xaml.cs
Outdated
Show resolved
Hide resolved
dansiegel
force-pushed
the
dev/ds/appbuilder-nav
branch
from
November 24, 2022 12:47
690ab07
to
49049e8
Compare
src/Uno.Extensions.Navigation.Toolkit/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Uno.Extensions.Navigation.Toolkit/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
dansiegel
force-pushed
the
dev/ds/appbuilder-nav
branch
from
November 24, 2022 15:16
49049e8
to
06be83a
Compare
nickrandolph
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Due to the overloaded extension in Toolkit Navigation you must provide special logic to handle when the Navigation Root is a Loading View and you must provide your own implementation to handle the ShowAsync for your Shell.
When providing
initialNavigate
it is ignored and not passed into InternalInitializeNavigationAsyncWhat is the new behavior?
IApplicationBuilder
has a new propertyDictionary<object, object> Properties
to maintain state when needed between extensions. A new extension is available to use Toolkit Navigation using theIApplicationBuilder
. An extension has been added to the core Navigation libraryShowAsync<TShell>
.The overload for
Window.InitializeNavigationAsync
in Toolkit Navigation is now obsolete and will cause an error if used with a message to use theIApplicationBuilder
.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.