Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed appxmanifest name on skia targets #132

Merged
merged 2 commits into from
May 10, 2023
Merged

Fixed appxmanifest name on skia targets #132

merged 2 commits into from
May 10, 2023

Conversation

pictos
Copy link
Contributor

@pictos pictos commented May 9, 2023

Fixes: #122

Now if the user doesn't specify the LogicalName we will use Package.appxmanifest as the default value.

@nickrandolph nickrandolph merged commit e2f4157 into main May 10, 2023
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the pj/skia-appxmanifest-rename branch May 10, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrandolph nickrandolph nickrandolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Skia] Package.appxmanifest incorrectly embedded
2 participants
@pictos @nickrandolph