Add code gen for setting UnoIcon on app Window #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dansiegel
force-pushed
the
dev/ds/seticononwindow
branch
from
556f289
to
2e0fa48
Compare
pictos
reviewed
May 11, 2023
pictos
reviewed
May 11, 2023
pictos
reviewed
May 11, 2023
dansiegel
force-pushed
the
dev/ds/seticononwindow
branch
from
f12bd05
to
6e2835b
Compare
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Update src/.nuspec/Uno.Resizetizer.targets Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
dansiegel
force-pushed
the
dev/ds/seticononwindow
branch
from
3863181
to
4b182b8
Compare
nickrandolph
approved these changes
May 11, 2023
|
@dansiegel the PR is falling with the following message Did we miss any reference? Or the namespace is different for WPF? |
|
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The developer needs to add native code to set the app's icon on the window
What is the new behavior?
Resizetizer generates a cross platform parameterless extension method on the window allowing the developer to easily set the icon on the window based on the UnoIcon provided.
Also normalizes the white space