Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create IntermediateOutputPath first if it doesn't exist #135

Merged
merged 1 commit into from
May 15, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@pictos
Copy link
Contributor

pictos commented May 15, 2023

@Youssef1313 I could not reproduce the issue using my PC or Macbook, but this change doesn't break anything... It's redundant since we create the folder on the tasks (on C# files). Can you confirm this change will fix your CI issues?

@Youssef1313
Copy link
Member Author

@pictos I confirmed this fixed it, and actually I'm able to reproduce locally, not only in CI.

To reproduce, I'm doing dotnet build while bin/obj are deleted. The IDE have to be closed because it will re-create them.

@pictos
Copy link
Contributor

pictos commented May 15, 2023

@Youssef1313 did you reproduce it on Windows or Mac?

@Youssef1313
Copy link
Member Author

On Windows.

@pictos
Copy link
Contributor

pictos commented May 15, 2023

I couldn't reproduce it locally either with our sample or using a project with the latest NuGet installed, following your steps. But this doesn't look to break anything, so I'll merge it.

Tks

@pictos pictos merged commit 8c5a1bb into unoplatform:main May 15, 2023
6 checks passed
@welcome
Copy link

welcome bot commented May 15, 2023

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

@Youssef1313 Youssef1313 deleted the patch-1 branch May 15, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants