Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incremental builds #143

Merged
merged 1 commit into from
May 30, 2023
Merged

Fixed incremental builds #143

merged 1 commit into from
May 30, 2023

Conversation

pictos
Copy link
Contributor

@pictos pictos commented May 30, 2023

This PR is a port of a fix implemented on #134 ticket.

Current Behavior

On the new template, if you rebuild the class lib project and press F5 or just build the head project, the Pwa manifest will not be updated nor the ApplicationIcon(for Skia targets). The reason is that the ResizetizerImages_v0 task will not be executed since the Inputs/Outputs will be evaluated as the same as the previous build.

PR Behavior

This PR adds a step to lookup the generated files and find the Pwa manifest and Application icon and include them in the build process.

@pictos pictos requested a review from nickrandolph May 30, 2023 14:32
@dansiegel dansiegel enabled auto-merge May 30, 2023 14:34
@dansiegel dansiegel merged commit 8fdbe6f into main May 30, 2023
6 checks passed
@dansiegel dansiegel deleted the pj/ported-cache-fix branch May 30, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants