Add Rider runtime configurations v2 #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…n configs by default
Takoooooo
force-pushed
the
dev/ds/rider-runtime-configs-v2
branch
from
2e9f197
to
bc3e037
Compare
|
Btw,@jeromelaban what did you mean by "Let's also add a readme file to explain what those files are"? Not sure where this file should be located and how should it work |
|
@dansiegel I've tested all configs on my machine, but it would be nice if you could test and review it on your machine too |
|
Closing, because Rider will support that soon-ish |
|
Keeping the PR until we'll actually implement that feature on our side |
|
❤️❤️❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to not include the .run configs for iOS,Android and MacCatalyst since they are included by default for me. If that's wouldn't be true for some of our users we can include them later anyway
GitHub Issue (If applicable): closes #676
based on #682
PR Type
What is the current behavior?
We don't provide Rider .run profiles
What is the new behavior?
We have Rider .run profiles