Skip to content

Commit

Permalink
build: Use compiler from SDK instead of NuGet package to reduce devel…
Browse files Browse the repository at this point in the history
…oper friction
  • Loading branch information
Youssef1313 committed Nov 26, 2023
1 parent 7681185 commit 09b7b6f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
5 changes: 1 addition & 4 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project ToolsVersion="15.0">
<Project>
<PropertyGroup>
<NoWarn>$(NoWarn);NU1507</NoWarn>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Net.Compilers.Toolset" PrivateAssets="all" />
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion samples/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<PackageVersion Include="Microsoft.Extensions.Logging" Version="5.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="5.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="5.0.0" />
<PackageVersion Include="Microsoft.Net.Compilers.Toolset" Version="4.7.0-2.final" />
<!--
If, in the same solution, you are referencing a project that uses https://github.com/onovotny/MSBuildSdkExtras,
you need to make sure that the version provided here matches https://github.com/novotnyllc/MSBuildSdkExtras/blob/main/Source/MSBuild.Sdk.Extras/DefaultItems/ImplicitPackages.targets#L11.
Expand Down
1 change: 0 additions & 1 deletion src/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
<PackageVersion Include="Uno.UITest.Xamarin" Version="1.1.0-dev.59" />
<PackageVersion Include="Xamarin.UITest" Version="4.1.4" />
<PackageVersion Include="MSTest.TestFramework" Version="2.1.2" />
<PackageVersion Include="Microsoft.Net.Compilers.Toolset" Version="4.7.0-2.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.0-preview1.22518.1" />
</ItemGroup>
</Project>

0 comments on commit 09b7b6f

Please sign in to comment.