Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port BindableVisualState #306

Closed
kazo0 opened this issue Aug 31, 2022 · 5 comments · Fixed by #339
Closed

Port BindableVisualState #306

kazo0 opened this issue Aug 31, 2022 · 5 comments · Fixed by #339
Assignees
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.

Comments

@kazo0
Copy link
Contributor

kazo0 commented Aug 31, 2022

https://github.com/nventive/Nventive.View/blob/master/doc/BindableVisualState.md

@kazo0 kazo0 added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Aug 31, 2022
@Xiaoy312 Xiaoy312 self-assigned this Sep 22, 2022
@Xiaoy312 Xiaoy312 changed the title Add BindableVisualState Port BindableVisualState and ViewDebugger Sep 23, 2022
@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Sep 23, 2022

summary: Provides a set of attached properties for adding custom visual state to a Control.
contract:

VisualStateExtensions
	.Group1State = (string)		// Sets the state to enter for the custom VisualStateGroup
	.Group2State = (string)		// Sets the state to enter for the custom VisualStateGroup 2
	.Group3State = ...
	.Group4State = ...

edit: the ViewDebugger parts has been move into its own issue #332, and will be implemented in a different class

@dr1rrb
Copy link
Member

dr1rrb commented Sep 23, 2022

Humm I think that we should not merge booth.

The ViewDebugger is something that should removed in release build like the System.Diagnostics.Debug (and we should probably flag all members with the [Conditional("DEBUG")] attribute (like the Debug class).

@Xiaoy312 Xiaoy312 changed the title Port BindableVisualState and ViewDebugger Port BindableVisualState Sep 23, 2022
@francoistanguay
Copy link
Contributor

Could we still merge into same class but different property named .NameOverride or .DebugName that is available in debug only?

Would be less clutter into single class with similar behaviour

@francoistanguay
Copy link
Contributor

And don't know why we call this a custom state?

@francoistanguay
Copy link
Contributor

Could we still merge into same class but different property named .NameOverride or .DebugName that is available in debug only?

Would be less clutter into single class with similar behaviour

Actually the debug is overkill and is I different from any hard coded property in xaml sinks keep the single bendable property and drop the debugger stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants