Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][IOS] SelectorExtensions.PipsPager does not work with ItemsSource #403

Closed
3 of 10 tasks
Marc-Antoine-Soucy opened this issue Nov 21, 2022 · 4 comments · Fixed by #565
Closed
3 of 10 tasks

[Android][IOS] SelectorExtensions.PipsPager does not work with ItemsSource #403

Marc-Antoine-Soucy opened this issue Nov 21, 2022 · 4 comments · Fixed by #565
Assignees
@Youssef1313
Labels
control/extensions-helpers-markup Related to attached properties, helper classes, or markup extensions without a finer tag kind/bug Something isn't working

Comments

@Marc-Antoine-Soucy
Copy link
Contributor

Marc-Antoine-Soucy commented Nov 21, 2022 •
edited
Loading

Current behavior

the pipsPager only detects items added manually from the xaml
image

Expected behavior

should work like on WinUI
image
pispager works and detects both items from item source and items added from the xaml.

How to reproduce it (as minimally and precisely as possible)

Open app, notice that one side gets the pipspager and the other does not.

App5.zip

Environment

Nuget Package:

Package Version(s):
uno.toolkit.winui 2.4.0-dev.115
uno.toolkit.winui.Material 2.4.0-dev.115

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Visual Studio:

  • 2017 (version: )
  • 2022 (version: 17.4.1)
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?
@Marc-Antoine-Soucy Marc-Antoine-Soucy added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Nov 21, 2022
@takla21
Copy link

takla21 commented Jan 16, 2023

Any updates on this?

@kazo0
Copy link
Contributor

kazo0 commented Jan 17, 2023

@pictos is this expected?

@Xiaoy312 Xiaoy312 added control/extensions-helpers-markup Related to attached properties, helper classes, or markup extensions without a finer tag and removed triage/untriaged Indicates an issue requires triaging or verification. labels Apr 28, 2023
@takla21
Copy link

takla21 commented May 8, 2023

@kazo0 @pictos Any news on this?

@Youssef1313
Copy link
Member

I'm going to take a look.

@Youssef1313 Youssef1313 mentioned this issue May 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
control/extensions-helpers-markup Related to attached properties, helper classes, or markup extensions without a finer tag kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix SelectorExtensions not updating NumberOfPages on Selector load Youssef1313/uno.toolkit.ui
5 participants
@Xiaoy312 @kazo0 @takla21 @Youssef1313 @Marc-Antoine-Soucy