Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SelectorExtensions not updating NumberOfPages on Selector load #565

Merged
merged 2 commits into from
May 25, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #403

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazo0
Copy link
Contributor

kazo0 commented May 24, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kazo0 kazo0 merged commit cccd79f into unoplatform:main May 25, 2023
39 of 40 checks passed
@Youssef1313 Youssef1313 deleted the selector-extensions branch May 25, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android][IOS] SelectorExtensions.PipsPager does not work with ItemsSource
5 participants