Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TabBar] Allow for easy customization of a selection indicator #460

Closed
kazo0 opened this issue Jan 27, 2023 · 0 comments · Fixed by #477
Closed

[TabBar] Allow for easy customization of a selection indicator #460

kazo0 opened this issue Jan 27, 2023 · 0 comments · Fixed by #477
Assignees
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.

Comments

@kazo0
Copy link
Contributor

kazo0 commented Jan 27, 2023

In order to achieve certain scenarios such as a custom sliding selection indicator:

sliding-tabbar

Or to simply customize the look of any given selection indicator, such as the default Material TopTabBarStyle's selection indicator:

image

We need to expose some properties that will allow us to inject any sort of content into the internal TabBarSelectionIndicatorPresenter

Spec

Option 1 (as properties on TabBar)

New TabBar Properties

Property Type Description
SelectionIndicatorContent object Gets or sets the content of the selection indicator
SelectionIndicatorContentTemplate DataTemplate Gets or sets the template to be used when displaying SelectionIndicatorContent
SelectionIndicatorTransitionMode SelectionIndicatorTransitionMode Determines the method for which the selection indicator will move to the selected tab. Values: .Snap , .Slide

Option 2 (as a standalone ContentControl)

TabBarSelectionIndicator

ObjectDependencyObjectUIElementFrameworkElementControlContentControlTabBarSelectionIndicator

Property Type Description
TransitionMode TransitionMode Determines the method for which the selection indicator will move to the newly selected tab. Values: .Snap , .Slide

New TabBar Properties

Property Type Description
SelectionIndicator TabBarSelectionIndicator Gets or sets the selection indicator used to display the currently selected TabBarItem
@kazo0 kazo0 added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Jan 27, 2023
@kazo0 kazo0 self-assigned this Jan 27, 2023
@kazo0 kazo0 closed this as completed in #477 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant