Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TabBar Selection Indicator Customization #477

Merged
merged 9 commits into from
Mar 2, 2023
Merged

Enable TabBar Selection Indicator Customization #477

merged 9 commits into from
Mar 2, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Feb 21, 2023 •
edited
Loading

closes #420
closes #460
closes #461

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

Allow for custom content of selection indicators. Allow Snap/Slide capabilities for selection indicator

Snap:
tabbar-selection-snap

Slide:
tabbar-selection-slide

@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 reviewed Feb 22, 2023
View reviewed changes
doc/controls/TabBarAndTabBarItem.md Outdated Show resolved Hide resolved
doc/controls/TabBarAndTabBarItem.md Outdated Show resolved Hide resolved
doc/controls/TabBarAndTabBarItem.md Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/TabBar/TabBar.Properties.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/TabBar/TabBarSelectionIndicatorPresenter.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/TabBar/TabBarSelectionIndicatorPresenter.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/TabBar/TabBarSelectionIndicatorPresenter.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/TabBar/TabBarSelectionIndicatorPresenterTemplateSettings.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/TabBar/TabBarTemplateSettings.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Uno.Toolkit.UI.csproj Outdated Show resolved Hide resolved
kazo0 and others added 3 commits February 24, 2023 15:34
@kazo0 @Xiaoy312
chore: pr comments
7bcd986 
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
@kazo0
chore: pr comments
e6cfb5d
@kazo0
chore: pr comments
b1d0278
@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

@kazo0 @Xiaoy312 @agneszitte
chore: pr comments
ea30bec 
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Agnès ZITTE <16295702+agneszitte-nventive@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 28, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) February 28, 2023 21:46
@github-actions
Copy link

github-actions bot commented Mar 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Mar 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-477.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit d0c07da into main Mar 2, 2023
@kazo0 kazo0 deleted the dev/sb/tabbar-indicator branch March 2, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kazo0 @Xiaoy312 @agneszitte