Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawer): IsLightDismissEnabled #1007

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Xiaoy312
Copy link
Contributor

GitHub Issue (If applicable): closes #1005

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

added IsLightDismissEnabled property for both DrawerControl and DrawerFlyoutPresenter that can be used to prevent light-dismiss.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Copy link
Contributor

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any runtime tests that we can write for this?

doc/controls/DrawerControl.md Show resolved Hide resolved
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240116/drawer--is-light-dismiss-enabled branch from b249e66 to 72f1c65 Compare January 16, 2024 22:25
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240116/drawer--is-light-dismiss-enabled branch from 72f1c65 to fae9f55 Compare January 16, 2024 22:25
@Xiaoy312 Xiaoy312 merged commit 0ea6f30 into main Jan 17, 2024
26 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20240116/drawer--is-light-dismiss-enabled branch January 17, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DrawerFlyout] option to dis/enable light-dismiss
4 participants