AutoLayout wasn't arranging stretched children when in ScrollViewer #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put inside a ScrollViewer
carldebilly
force-pushed
the
dev/cdb/autolayout-in-scrollviewer
branch
from
c715db0
to
d9faac5
Compare
Robert-Louis
approved these changes
Jan 31, 2024
|
https://github.com/Mergifyio backport release/stable/5.1 |
✅ Backports have been created
|
kazo0
approved these changes
Jan 31, 2024
jeromelaban
added a commit
that referenced
this pull request
Feb 1, 2024
….1/pr-1023 AutoLayout wasn't arranging stretched children when in ScrollViewer (backport #1023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1022
Bugfix
What is the current behavior?
As described in the issue, a stretched child of an AutoLayout were not properly arranged when inside a ScrollViewer.
What is the new behavior?
When the
finalSizeis different than the one used to measure the element (which is the case in a ScrollViewer), it was incorrectly using the measured size instread of recalculating it using thefinalSize.PR Checklist
Please check if your PR fulfills the following requirements: