Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ExtendedSplashScreen): add android 12 splashscreen support #1060

Merged
merged 4 commits into from
Mar 13, 2024
Merged

feat(ExtendedSplashScreen): add android 12 splashscreen support #1060

merged 4 commits into from
Mar 13, 2024

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Mar 4, 2024 •
edited
Loading

fixes #1054

Left is API 34, Right is API 28
splash-ezgif com-video-to-gif-converter

@kazo0 kazo0 marked this pull request as draft March 4, 2024 04:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@kazo0 kazo0 marked this pull request as ready for review March 5, 2024 14:23
pictos
pictos reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some comments that I think we can delete, but it doesn't invalidate the PR

samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Shell.xaml Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Android.cs Show resolved Hide resolved
pictos
pictos approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some comments that I think we can delete, but it doesn't invalidate the PR

pictos
pictos approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some comments that I think we can delete, but it doesn't invalidate the PR

Xiaoy312
Xiaoy312 approved these changes Mar 11, 2024
View reviewed changes
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Mobile/Android/MainActivity.Android.cs Outdated Show resolved Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Shell.xaml Outdated Show resolved Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Shell.xaml Outdated Show resolved Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Shell.xaml Show resolved Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Shell.xaml.cs Outdated Show resolved Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Shell.xaml.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Android.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Android.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Android.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/SystemUiConfig.Android.cs Outdated Show resolved Hide resolved
@kazo0 kazo0 force-pushed the dev/sb/android-extended-splash branch from 1b0ab5e to 0b46928 Compare March 11, 2024 16:55
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@kazo0 kazo0 force-pushed the dev/sb/android-extended-splash branch from 8b64747 to d52588d Compare March 11, 2024 23:44
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@kazo0 @agneszitte
docs: pr comments
1cfc3ef 
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
@kazo0 kazo0 enabled auto-merge (squash) March 13, 2024 00:02
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1060.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 99a0fe0 into main Mar 13, 2024
26 checks passed
@kazo0 kazo0 deleted the dev/sb/android-extended-splash branch March 13, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@agneszitte agneszitte agneszitte approved these changes

@pictos pictos pictos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ExtendedSplashScreen][Android] Content does not match native splash screen
4 participants
@kazo0 @Xiaoy312 @agneszitte @pictos