chore: chip selection rework #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
commented
Dec 7, 2022
Xiaoy312
force-pushed
the
dev/xygu/20221206/chip-select-rework
branch
2 times, most recently
from
7e6d472
to
5361998
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-422.eastus2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-422.eastus2.azurestaticapps.net |
kazo0
approved these changes
Dec 8, 2022
Xiaoy312
force-pushed
the
dev/xygu/20221206/chip-select-rework
branch
from
5361998
to
16a7509
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-422.eastus2.azurestaticapps.net |
Xiaoy312
force-pushed
the
dev/xygu/20221206/chip-select-rework
branch
from
16a7509
to
37a7dfc
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-422.eastus2.azurestaticapps.net |
nickrandolph
reviewed
Dec 9, 2022
nickrandolph
approved these changes
Dec 9, 2022
Xiaoy312
force-pushed
the
dev/xygu/20221206/chip-select-rework
branch
from
37a7dfc
to
a62b5eb
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-422.eastus2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #337, closes #354, re: #356
PR Type
What kind of change does this PR introduce?
What is the new behavior?
ChipGroupselection logicsSingleselection mode now enforces a default selection and prevent the deselection of currently selected item (RadioGroup-like)Singleselection mode is available asSingleOrNonePR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information