Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autolayout): conflict with padding and spacing vs primary alignment #443

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

Robert-Louis
Copy link
Contributor

GitHub Issue (If applicable): #436

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • when absolute positionned element was under the padding and the padding same size or less than spacing, the element was not properly positionned.
    image
  • when PrimaryAxisAlignment="Center" or "End" and one item set to fill and a other item was absolute positionned the autolayout behaved like if not items was fill
    image

What is the new behavior?

  • absolute position with margin and padding behave as expected
    image
  • spacebeetween margin fixes
    image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

…nt. Spacing is now handle directly by the control.
@Robert-Louis Robert-Louis self-assigned this Jan 12, 2023
@Robert-Louis Robert-Louis linked an issue Jan 12, 2023 that may be closed by this pull request
@carldebilly carldebilly changed the title fix(autolayout): conflict with padding and spacing and primary alignment fix(autolayout): conflict with padding and spacing vs primary alignment Jan 12, 2023
@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-443.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jan 13, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-443.eastus2.azurestaticapps.net

@Robert-Louis Robert-Louis merged commit 0f5f684 into main Jan 16, 2023
@Robert-Louis Robert-Louis deleted the dev/rlm/spacing-and-spacebetween branch January 16, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AutoLayout Absolute Positioning producing incorrect result
2 participants