Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unnecessary GestureInterceptorMargin and TrueToVisible converter in the DrawerControl style to fix UWP Sample #448

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: Remove unnecessary GestureInterceptorMargin and TrueToVisible converter in the DrawerControl style to fix UWP Sample #448

merged 2 commits into from
Jan 16, 2023

Conversation

agneszitte
Copy link
Contributor

@agneszitte agneszitte commented Jan 13, 2023 •
edited
Loading

GitHub Issue (If applicable): #290, #9487

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Remove unused GestureInterceptorMargin TemplateBinding in the DrawerControl style to fix UWP Sample

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

re: unoplatform/uno#290

@github-actions
Copy link

github-actions bot commented Jan 13, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-448.eastus2.azurestaticapps.net

@agneszitte agneszitte enabled auto-merge (squash) January 13, 2023 21:15
fix: Correctly use the already available MaterialTrueToVisible conver…
03fb622 
…ter from Uno.Themes and removing the unecessary TrueToVisible converter
@agneszitte agneszitte changed the title fix: Remove unused GestureInterceptorMargin TemplateBinding in the DrawerControl style to fix UWP Sample fix: Remove unnecessary GestureInterceptorMargin and TrueToVisible converter in the DrawerControl style to fix UWP Sample Jan 13, 2023
@github-actions
Copy link

github-actions bot commented Jan 13, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-448.eastus2.azurestaticapps.net

@agneszitte agneszitte merged commit ec3ccea into main Jan 16, 2023
@agneszitte agneszitte deleted the dev/agzi/FixUWPDrawerControlSample branch January 16, 2023 16:16
@agneszitte agneszitte mentioned this pull request Jan 19, 2023
Open
@agneszitte agneszitte restored the dev/agzi/FixUWPDrawerControlSample branch January 27, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@kazo0 kazo0 kazo0 approved these changes

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agneszitte @Xiaoy312 @kazo0