Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AutoLayout): Properly call the UpdateAutoLayout method during the OnLoaded #462

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

agneszitte
Copy link
Contributor

@agneszitte agneszitte commented Jan 27, 2023

GitHub Issue (If applicable): #https://github.com/unoplatform/uno.chefs/issues/178

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

AutoLayout IsLoaded return false for all platforms except WinUI
(Explain by the fact that the sequence of events is different between Windows and WinUI)

What is the new behavior?

Properly call the UpdateAutoLayout method during the OnLoaded that way IsLoaded is "true" for all platforms at the correct time

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Jan 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-462.eastus2.azurestaticapps.net

@agneszitte agneszitte enabled auto-merge (squash) January 27, 2023 17:21
@github-actions
Copy link

github-actions bot commented Jan 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-462.eastus2.azurestaticapps.net

@agneszitte agneszitte enabled auto-merge (squash) January 27, 2023 18:23
@agneszitte agneszitte merged commit c5a41d4 into main Jan 27, 2023
@agneszitte agneszitte deleted the dev/agzi/I178-OnLoaded branch January 27, 2023 19:28
@jeromelaban
Copy link
Member

@agneszitte-nventive could this be tested with a runtime test?

@agneszitte
Copy link
Contributor Author

agneszitte commented Jan 27, 2023

@agneszitte-nventive could this be tested with a runtime test?

@jeromelaban I will verify but I think there is maybe a way. I will do another PR to add some tests if it is possible

pull bot pushed a commit to ehtick/uno.toolkit.ui that referenced this pull request Jan 28, 2023
@agneszitte
Copy link
Contributor Author

agneszitte commented Feb 2, 2023

@jeromelaban / @kazo0 I will wait for this PR #471 to be merged first in order to add a runtime test for the AutoLayout control.
(This PR introduces a new UITest to kick off the Toolkit Runtime Tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants