fix(AutoLayout): Properly call the UpdateAutoLayout method during the OnLoaded #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-462.eastus2.azurestaticapps.net |
carldebilly
approved these changes
Jan 27, 2023
kazo0
approved these changes
Jan 27, 2023
dr1rrb
approved these changes
Jan 27, 2023
…e updating the layout (#458)
agneszitte
force-pushed
the
dev/agzi/I178-OnLoaded
branch
from
68d9a76
to
ddb411b
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-462.eastus2.azurestaticapps.net |
|
@agneszitte-nventive could this be tested with a runtime test? |
@jeromelaban I will verify but I think there is maybe a way. I will do another PR to add some tests if it is possible |
pull bot
pushed a commit
to ehtick/uno.toolkit.ui
that referenced
this pull request
Jan 28, 2023
…e updating the layout (unoplatform#458) (unoplatform#462)
|
@jeromelaban / @kazo0 I will wait for this PR #471 to be merged first in order to add a runtime test for the AutoLayout control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #https://github.com/unoplatform/uno.chefs/issues/178
PR Type
What kind of change does this PR introduce?
What is the current behavior?
AutoLayout IsLoaded return false for all platforms except WinUI
(Explain by the fact that the sequence of events is different between Windows and WinUI)
What is the new behavior?
Properly call the UpdateAutoLayout method during the OnLoaded that way IsLoaded is "true" for all platforms at the correct time
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):