Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing framework reference requirement #476

Merged
merged 8 commits into from
Feb 23, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When adding toolkit to a WinUI project, it's necessary to update the frameworkreference - hard for developers to diagnose

What is the new behavior?

Toolkit should be able to be added to winui project without affecting compilation or requiring additional steps

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-476.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-476.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-476.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-476.eastus2.azurestaticapps.net

@nickrandolph nickrandolph merged commit e718c4e into main Feb 23, 2023
@nickrandolph nickrandolph deleted the dev/nr/removfxref branch February 23, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants