Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cards): add IsClickable property #481

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

Xiaoy312
Copy link
Contributor

GitHub Issue (If applicable): closes #465

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Card and CardContentControl always respond to pointer & focus events, with no way of disabling this behavior.

What is the new behavior?

This behavior can now be toggled with the new IsClickable property on both controls, that is set to true by default.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):
closes unoplatform/uno.chefs#113

@Xiaoy312 Xiaoy312 enabled auto-merge (squash) February 24, 2023 20:10
@Xiaoy312
Copy link
Contributor Author

@carldebilly @Robert-Louis FYI, a new IsClickable property will be added to Card and CardContentControl, possibly something we want to edit from Figma too.

@Xiaoy312
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230224/card-isclickable branch from 272f637 to dc3038f Compare March 1, 2023 19:47
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-481.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit f311d14 into main Mar 2, 2023
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20230224/card-isclickable branch March 2, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material][Card][CardContentControl] Add IsClickable to enable/disable pointer visual states
3 participants