Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AutoLayout): remove issue where padding did not behave expectedly #496

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

Robert-Louis
Copy link
Contributor

GitHub Issue (If applicable): #
https://github.com/unoplatform/Uno.Figma/issues/1080

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • When autolayout is in space between mode and a children is independant and have a padding, the padding don't behave as expected.

This is due to a grid bug when height is discard. the work around is to also set the MaxHeight

What is the new behavior?

  • The padding behave as expected is this configuration

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-496.eastus2.azurestaticapps.net

Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use the closing keywords to associate this to the issue:

eg: closes unoplatform/Uno.Figma#1080

src/Uno.Toolkit.RuntimeTests/Tests/AutoLayoutTest.cs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-496.eastus2.azurestaticapps.net

@Robert-Louis Robert-Louis merged commit aaecaaf into main Mar 10, 2023
@Robert-Louis Robert-Louis deleted the dev/rlm/absolutePosition branch March 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants