Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TabBar issues #502

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: TabBar issues #502

merged 1 commit into from
Mar 15, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Mar 14, 2023 •
edited
Loading

closes #501

PR Type

What kind of change does this PR introduce?

  • Bugfix

Changes

  • Fix for calling ContainerFromIndex with a -1 value
  • Fix for TabBarSelectorBehavior interfering with sliding indicator

agneszitte
agneszitte approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests can be added for these changes ?

@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net

@kazo0 kazo0 changed the title Dev/sb/tabbar fixes fix: TabBar issues Mar 14, 2023
@kazo0
Copy link
Contributor Author

kazo0 commented Mar 14, 2023

Some tests can be added for these changes ?

I'm not sure how to test the sliding indicator, need to think about it

@Xiaoy312
Copy link
Contributor

set selection index, and WaitFor the animated value (eg: transform.x) to reach the expected value?

@kazo0
Copy link
Contributor Author

kazo0 commented Mar 14, 2023

yeah thats what i am doing now, i was thinking more about the "in between" sliding when you are scrolling a FlipView and it should slide along based on the scroll offset. Testing for the indicator moving from item to item on selection is fine but the issue here was that it wasn't properly sliding to its destination

@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) March 15, 2023 12:07
@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit fccc8a8 into main Mar 15, 2023
@kazo0 kazo0 deleted the dev/sb/tabbar-fixes branch March 15, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] TabBar WinAppSDK Memory crash
5 participants
@kazo0 @Xiaoy312 @jeromelaban @agneszitte @Youssef1313