Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemsRepeaterExtensions fixes #538

Merged
merged 3 commits into from
Apr 17, 2023
Merged

ItemsRepeaterExtensions fixes #538

merged 3 commits into from
Apr 17, 2023

Conversation

Xiaoy312
Copy link
Contributor

GitHub Issue (If applicable): closes unoplatform/uno.chefs#107

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

fixed exception being throw in ItemsRepeaterExtensions when using SelectedItem binding (from source).

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

agneszitte
agneszitte approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some tests? (cc @kazo0)

@agneszitte agneszitte requested a review from kazo0 April 12, 2023 13:27
@Xiaoy312
Copy link
Contributor Author

test? yes! i will get to them after my animation prs

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230411/ir-ext-fix branch 2 times, most recently from d17e51f to 1d429ee Compare April 13, 2023 18:24
@Xiaoy312 Xiaoy312 changed the title fix: IRExtension SelectedItem crash ItemsRepeaterExtensions fixes Apr 13, 2023
@Xiaoy312 Xiaoy312 enabled auto-merge (squash) April 13, 2023 18:24
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230411/ir-ext-fix branch from 1d429ee to 16aeb85 Compare April 17, 2023 17:57
@Xiaoy312
Copy link
Contributor Author

update: rebased the branch for ios ci fix and azure static webapp fix

@Xiaoy312 Xiaoy312 merged commit e38ebad into main Apr 17, 2023
31 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20230411/ir-ext-fix branch April 17, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xiaoy312 @kazo0 @jeromelaban @agneszitte