fix(ChipGroup): Chip.Icon being overwritten #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agneszitte
approved these changes
Apr 28, 2023
Xiaoy312
force-pushed
the
dev/xygu/20230428/chipgroup-icon
branch
from
132fc63
to
41d020b
Compare
kazo0
approved these changes
Apr 28, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run edit: the pipeline linking should've be fixed, right? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as off-topic.
This comment was marked as off-topic.
jeromelaban
reviewed
May 2, 2023
Xiaoy312
force-pushed
the
dev/xygu/20230428/chipgroup-icon
branch
from
41d020b
to
525ad5f
Compare
Xiaoy312
force-pushed
the
dev/xygu/20230428/chipgroup-icon
branch
from
525ad5f
to
9082cfa
Compare
roubachof
pushed a commit
to sharpnado-pro/uno.toolkit.ui
that referenced
this pull request
May 16, 2023
roubachof
pushed a commit
to sharpnado-pro/uno.toolkit.ui
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #557
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Chip.Iconwill be overwritten by null if used in aChipGroupWhat is the new behavior?
^ no more.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information