Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TabBar): Don't call SelectedIndex setter with the same old value to let it work with bindings #566

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 10, 2023

GitHub Issue (If applicable): Closes #562

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313
Copy link
Member Author

@kazo0 @Xiaoy312 Does this sound reasonable?

@Youssef1313 Youssef1313 requested a review from kazo0 May 15, 2023 16:13
@kazo0
Copy link
Contributor

kazo0 commented May 24, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Xiaoy312 Xiaoy312 merged commit 4409fb2 into unoplatform:main Jul 12, 2023
31 checks passed
@Youssef1313 Youssef1313 deleted the tabbar branch July 12, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows][TabBar] SelectedIndex doesn't update selected item visual state
4 participants