fix: SpaceBetween causing wrong size #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-590.eastus2.azurestaticapps.net |
Robert-Louis
approved these changes
Jun 8, 2023
carldebilly
approved these changes
Jun 8, 2023
|
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we'd love to pay it forward by sending you some swag. If you have any feedback (or ideas on how to improve the Uno Toolkit as an open-source project) please open a feedback issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Fixes #588
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In very specific cases, having SpaceBetween set, one fixed dimension parent and fixed size children, calculated parent dimension was been generated smaller then expected.
What is the new behavior?
Now, parent size is been calculated as expected.
PR Checklist
Please check if your PR fulfills the following requirements: