Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Theme): Fixed the theme toggle button for windows and WASM #592

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

@Marc-Antoine-Soucy Marc-Antoine-Soucy commented Jun 6, 2023

GitHub Issue (If applicable): #
closes #546

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When you press on the theme toggle button WinUI and Wasm, it doesnt change the theme.

What is the new behavior?

Every time you press on the toggle button, it changes the theme.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

#546

@Marc-Antoine-Soucy Marc-Antoine-Soucy self-assigned this Jun 6, 2023
@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review June 6, 2023 20:52
@kazo0 kazo0 merged commit 7e9da83 into main Jun 12, 2023
31 checks passed
@kazo0 kazo0 deleted the dev/maso/changetheme branch June 12, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SampleApp] Light/Dark toggle not working
2 participants