Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NavigationView): Made content visible when the NavigationView is … #601

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

…open

GitHub Issue (If applicable): #
#544

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When you press on the button to close the navigation view, it stays open and hides the content of the navigationview, if you press it again, it partially hides the navigationview, but it doesnt work anymore.

What is the new behavior?

When you press the button to close the navigation view, it hides the navigationview. When you press it again, you can still se the content of the navigationview.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review June 7, 2023 18:56
@kazo0 kazo0 merged commit 5b56af5 into main Jun 9, 2023
31 checks passed
@kazo0 kazo0 deleted the dev/maso/navigationview branch June 9, 2023 18:03
@welcome
Copy link

welcome bot commented Jun 9, 2023

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we'd love to pay it forward by sending you some swag. If you have any feedback (or ideas on how to improve the Uno Toolkit as an open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants