Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tabbar): Add lightweight styling to tab bar style #604

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

nguyeenvy
Copy link
Contributor

@nguyeenvy nguyeenvy commented Jun 12, 2023

closes #594

GitHub Issue (If applicable): #594

PR Type

  • Refactoring (no functional changes, no api changes)

Description

Current behaviour:
image

Overriden:
image

Overriden with:

<Page.Resources>
    <SolidColorBrush x:Key="TopTabBarItemBackground" Color="Red" />
    <SolidColorBrush x:Key="TopTabBarItemBackgroundPointerOver" Color="Orange" />
    <SolidColorBrush x:Key="TopTabBarItemBackgroundFocused" Color="Yellow" />
    <SolidColorBrush x:Key="TopTabBarItemBackgroundPressed" Color="Green" />
    <SolidColorBrush x:Key="TopTabBarItemBackgroundDisabled" Color="Blue" />
    <SolidColorBrush x:Key="TopTabBarItemBackgroundSelected" Color="Indigo" />
    <SolidColorBrush x:Key="TopTabBarItemBackgroundSelectedPointerOver" Color="Pink" />
    <SolidColorBrush x:Key="TopTabBarItemBackgroundSelectedPressed" Color="Red" />

    <SolidColorBrush x:Key="TopTabBarItemForeground" Color="Orange" />
    <SolidColorBrush x:Key="TopTabBarItemForegroundPointerOver" Color="Yellow" />
    <SolidColorBrush x:Key="TopTabBarItemForegroundFocused" Color="Green" />
    <SolidColorBrush x:Key="TopTabBarItemForegroundPressed" Color="Blue" />
    <SolidColorBrush x:Key="TopTabBarItemForegroundDisabled" Color="Indigo" />
    <SolidColorBrush x:Key="TopTabBarItemForegroundSelected" Color="Pink" />
    <SolidColorBrush x:Key="TopTabBarItemForegroundSelectedPointerOver" Color="Red" />
    <SolidColorBrush x:Key="TopTabBarItemForegroundSelectedPressed" Color="Orange" />

    <SolidColorBrush x:Key="TopTabBarItemBorderBrush" Color="Yellow" />

    <SolidColorBrush x:Key="TopTabBarItemIconForeground" Color="Green" />
    <SolidColorBrush x:Key="TopTabBarItemIconForegroundPointerOver" Color="Blue" />
    <SolidColorBrush x:Key="TopTabBarItemIconForegroundFocused" Color="Indigo" />
    <SolidColorBrush x:Key="TopTabBarItemIconForegroundPressed" Color="Pink" />
    <SolidColorBrush x:Key="TopTabBarItemIconForegroundDisabled" Color="Red" />
    <SolidColorBrush x:Key="TopTabBarItemIconForegroundSelected" Color="Orange" />
    <SolidColorBrush x:Key="TopTabBarItemIconForegroundSelectedPointerOver" Color="Yellow" />
    <SolidColorBrush x:Key="TopTabBarItemIconForegroundSelectedPressed" Color="Green" />

    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrush" Color="Blue" />
    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrushPointerOver" Color="Indigo" />
    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrushFocused" Color="Pink" />
    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrushPressed" Color="Red" />
    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrushDisabled" Color="Orange" />
    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrushSelected" Color="Yellow" />
    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrushSelectedPointerOver" Color="Green" />
    <SolidColorBrush x:Key="TopTabBarItemPointerFillBrushSelectedPressed" Color="Blue" />

    <SolidColorBrush x:Key="TopTabBarItemRippleFeedback" Color="Indigo" />
</Page.Resources>

PR Checklist

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-604.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy self-assigned this Jun 12, 2023
@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-TabBar-Style branch from 37ec29f to feab53f Compare June 12, 2023 16:46
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-604.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-TabBar-Style branch from afd3a96 to 43e162c Compare June 14, 2023 20:00
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-604.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-604.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-TabBar-Style branch from 88d59f1 to 222ac53 Compare June 22, 2023 20:33
@nguyeenvy nguyeenvy requested a review from kazo0 June 22, 2023 20:33
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-604.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-604.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 7ac3275 into main Jun 27, 2023
31 checks passed
@kazo0 kazo0 deleted the dev/vyng/Lightweight-Styling-TabBar-Style branch June 27, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material][TabBar] Add lightweight styling support for TabBar Material style
2 participants