Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default back button icon for NavBar #614

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

silviuo
Copy link
Contributor

@silviuo silviuo commented Jun 15, 2023

GitHub Issue (If applicable): #

closes #545
closes #321

PR Type

What kind of change does this PR introduce?

What is the current behavior?

On Android and iOS the native bars are rendered which display the platform's native back button icon. This was not the case on non-mobile platforms.

What is the new behavior?

Non-mobile platforms now have a default back button icon for NavBar.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@silviuo silviuo requested a review from kazo0 June 15, 2023 19:37
@kazo0 kazo0 merged commit 2b3a5f2 into main Jun 22, 2023
31 checks passed
@kazo0 kazo0 deleted the Dev/siob/fix-back-navbar branch June 22, 2023 19:10
@welcome
Copy link

welcome bot commented Jun 22, 2023

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we'd love to pay it forward by sending you some swag. If you have any feedback (or ideas on how to improve the Uno Toolkit as an open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants