Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix iOS Xamarin.Calabash call on NET7 #651

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: Fix iOS Xamarin.Calabash call on NET7 #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
/// <param name="e">Details about the launch request and process.</param>
protected override async void OnLaunched(XamlLaunchActivatedEventArgs e)
{
#if __IOS__ && !NET6_0 && USE_UITESTS
#if __IOS__ && !NET6_0_OR_GREATER && USE_UITESTS
Xamarin.Calabash.Start();
#endif

Expand All @@ -108,7 +108,7 @@
#if IS_WINUI
SplashScreen = e.UWPLaunchActivatedEventArgs.SplashScreen,
#else
SplashScreen = e.SplashScreen,

Check warning on line 111 in samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.cs

View workflow job for this annotation

GitHub Actions / Build and Deploy Job 

Windows.ApplicationModel.Activation.LaunchActivatedEventArgs.SplashScreen is not implemented in Uno (https://aka.platform.uno/notimplemented?m=Windows.ApplicationModel.Activation.LaunchActivatedEventArgs.SplashScreen)

Check warning on line 111 in samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.cs

View workflow job for this annotation

GitHub Actions / Build and Deploy Job 

Windows.ApplicationModel.Activation.LaunchActivatedEventArgs.SplashScreen is not implemented in Uno (https://aka.platform.uno/notimplemented?m=Windows.ApplicationModel.Activation.LaunchActivatedEventArgs.SplashScreen)
#endif
Source = loadable
};
Expand Down
Loading