Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShadowContainer][Wasm] Shadow Builder - Delay visible when adding/removing shadows or switching to Light/Dark #838

Closed

Conversation

rafael-rosa-knowcode
Copy link
Contributor

GitHub Issue (If applicable): closes: #976

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Shadow Builder - Delay visible when adding/removing shadows or switching to Light/Dark for Wasm
(should be carefully tested on the other platforms)

What is the new behavior?

No delay visible

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@roubachof
Copy link
Contributor

Careful: invalidating the canvas layout and invalidating the skia canvas are 2 different things.
We can't just delete an invalidation cause it seems to fix an issue.
Let me try to fix the perf issues in #830.

@roubachof roubachof closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants