Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StatusBar): OS theme change no longer crashes app #867

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

silviuo
Copy link
Contributor

@silviuo silviuo commented Oct 10, 2023

GitHub Issue (If applicable): closes #866, closes unoplatform/uno.chefs#666

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

On pages using StatusBar, apps using Toolkit.UI crash when changing the Windows OS theme in the OS Settings:
"The application called an interface that was marshalled for a different thread. (0x8001010E (RPC_E_WRONG_THREAD))"

What is the new behavior?

No crash

PR Checklist

Please check if your PR fulfills the following requirements:

@silviuo silviuo requested a review from kazo0 October 10, 2023 14:28
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-867.eastus2.azurestaticapps.net

@kazo0 kazo0 requested a review from Xiaoy312 October 10, 2023 14:44
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for this, if possible?

@silviuo
Copy link
Contributor Author

silviuo commented Oct 16, 2023

@kazo0 I pushed the Windows conditional changes without any runtime tests

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-867.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-867.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) October 16, 2023 18:25
@kazo0 kazo0 merged commit 4e2e33c into main Oct 16, 2023
24 checks passed
@kazo0 kazo0 deleted the dev/siob/win-crash-theme branch October 16, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Crash on system theme change on pages using StatusBar
4 participants