Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: templatebind background to ios navbar template #876

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Oct 14, 2023

fixes #874

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

image

What is the new behavior?

image

Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, this is just a visual bug with the sample, and not the logic/calculation of safe area?

@kazo0
Copy link
Contributor Author

kazo0 commented Oct 15, 2023

It's actually something in UIKit, the safe area reported by the os is larger than the native bars that it draws and we don't have control over the height of the UINavigationBar

dotnet/maui#16617

https://useyourloaf.com/blog/iphone-14-screen-sizes/

@kazo0 kazo0 merged commit 741fdaf into main Oct 17, 2023
24 checks passed
@kazo0 kazo0 deleted the dev/sb/ios-navbar-space branch October 17, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Dynamic Island] NavigationBar extra bottom spacing
3 participants