Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ResExpr): prevent unnecessary updates #953

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Dec 6, 2023

GitHub Issue (If applicable): closes #951

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

ResponsiveExpression performs value conversion and binding update on at every size changed proc.

What is the new behavior?

  • ^ it will only do so when significant layout change (eg: going from Normal->Wide) has occurred since last update.
  • improved TreeGraph output details for ResponsiveView & ResponsiveExpression
  • refactored ResponsiveView's & ResponsiveExpression's shared logics into ResponsiveHelper

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@Xiaoy312 Xiaoy312 changed the title fix(sampleapp): debug POI resolution perf(ResExpr): prevent unnecessary updates Dec 6, 2023
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Dec 6, 2023

saving top comment

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231206/res-value-perf branch from 0a6c2a5 to cb49fce Compare December 7, 2023 15:44
Copy link

github-actions bot commented Dec 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-953.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit f74d76a into main Dec 7, 2023
24 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20231206/res-value-perf branch December 7, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResponsiveExpression performance
2 participants