Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/xyguy/20231207/responsive-attached-property #957

Merged
merged 9 commits into from
Dec 20, 2023
Merged

Dev/xyguy/20231207/responsive-attached-property #957

merged 9 commits into from
Dec 20, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Dec 8, 2023

GitHub Issue (If applicable): closes #956, closes #955

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

What is the current behavior?

What is the new behavior?

  • fixed a bug with dp lookup
  • added attached property support for ResponsiveExpression

PR Checklist

Please check if your PR fulfills the following requirements:

@Xiaoy312 Xiaoy312 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2023
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Dec 8, 2023 •
edited
Loading

todo:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-957.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Dec 19, 2023

@Xiaoy312 now that unoplatform/uno#14749 is closed, is this still wip?

@Xiaoy312
Copy link
Contributor Author

not anymore :D

@Xiaoy312 Xiaoy312 force-pushed the dev/xyguy/20231207/responsive-attached-property branch from a06b723 to 9ad5a18 Compare December 19, 2023 17:05
@Xiaoy312 Xiaoy312 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
@Xiaoy312 Xiaoy312 marked this pull request as ready for review December 19, 2023 17:06
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-957.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-957.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) December 20, 2023 00:56
@kazo0 kazo0 disabled auto-merge December 20, 2023 03:50
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-957.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-957.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-957.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-957.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) December 20, 2023 21:20
@kazo0 kazo0 merged commit e5ce796 into main Dec 20, 2023
24 checks passed
@kazo0 kazo0 deleted the dev/xyguy/20231207/responsive-attached-property branch December 20, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Xiaoy312 @kazo0