Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(responsive): layout breakpoint calculation #966

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Dec 14, 2023

GitHub Issue (If applicable): closes #965

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

given only {normal, wide, widest} are provided:
image

What is the new behavior?

image

PR Checklist

Please check if your PR fulfills the following requirements:

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-966.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231213/responsive-layout-breakpoints branch from 3690ecc to 13a740f Compare December 14, 2023 00:50
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Dec 14, 2023

todo@xy:

  • add tests

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-966.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231213/responsive-layout-breakpoints branch from 13a740f to fd0a24d Compare December 14, 2023 21:40
@Xiaoy312 Xiaoy312 marked this pull request as ready for review December 14, 2023 21:40
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-966.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231213/responsive-layout-breakpoints branch from fd0a24d to b5398d9 Compare December 15, 2023 15:17
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231213/responsive-layout-breakpoints branch from b5398d9 to 8f6289e Compare December 15, 2023 15:17
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-966.eastus2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-966.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit 9a567d2 into main Dec 15, 2023
24 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20231213/responsive-layout-breakpoints branch December 15, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Responsive] fix ResponsiveHelper.ResolveLayout logics
4 participants