Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gtk] Reduce the number of assemblies in the sample rd.xml for Native AOT #10355

Closed
jeromelaban opened this issue Nov 7, 2022 · 4 comments
Closed

[Gtk] Reduce the number of assemblies in the sample rd.xml for Native AOT #10355

jeromelaban opened this issue Nov 7, 2022 · 4 comments
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request platform/gtk Categorizes an issue or PR as relevant to GTK project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools

Comments

@jeromelaban
Copy link
Member

Following #10351, the number of assemblies found in the rd.xml file can be reduced or cleared based on changes made in GtkSharp.

Let's evaluate which ones can be removed and see how many features we can get running.
@jeromelaban jeromelaban added kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. platform/gtk Categorizes an issue or PR as relevant to GTK labels Nov 7, 2022
@jeromelaban jeromelaban mentioned this issue Nov 7, 2022
Merged
6 tasks
@kant2002
Copy link

kant2002 commented Nov 9, 2022

Isn't this DOA (Done on arrival) ?

@jeromelaban
Copy link
Member Author

It definitely is :D Thanks!

@jeromelaban jeromelaban reopened this Nov 14, 2022
@jeromelaban
Copy link
Member Author

Let's reopen as:

<Directives>
	<Application>
		<Assembly Name="GdkSharp">
			<Type Name="Gdk.Screen" Dynamic="Required All"/>
		</Assembly>
		<Assembly Name="GtkSharp">
			<Type Name="Gtk.WindowStateEventArgs" Dynamic="Required All"/>
		</Assembly>
	</Application>
</Directives>

is not enough to make the app work.

@MartinZikmund MartinZikmund added difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers area/skia ✏️ Categorizes an issue or PR as relevant to Skia and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 16, 2023
@MartinZikmund
Copy link
Member

This is no longer relevant as GTK is kept for legacy purposes only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request platform/gtk Categorizes an issue or PR as relevant to GTK project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinZikmund @kant2002 @jeromelaban