Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Regression] SafeAreaPaddings are applied by default #16503

Open
marwalsch opened this issue Apr 29, 2024 · 6 comments
Open

[iOS][Regression] SafeAreaPaddings are applied by default #16503

marwalsch opened this issue Apr 29, 2024 · 6 comments
Assignees
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@marwalsch
Copy link

marwalsch commented Apr 29, 2024

Current behavior

This screenshot was taken with Uno.WinUI 5.1.104:

Image (2)

As you can see, the page's grey background reaches beyond the status bar and the dock. This behaviour is intended (at least this was the default up until now).


This is the same view with Uno.WinUI 5.2.94:

Image

The page is enclosed by the status bar and the dock. To me it looks a lot like as id SafeAreaPaddings are enabled.

Expected behavior

The page should reach beyond the status bar and the dock and dictate its background.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

Uno.WinUI 5.2.94/5.3.0-dev.798

Affected platforms

iOS

@marwalsch marwalsch added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Apr 29, 2024
@jeromelaban
Copy link
Member

@kazo0 does this look familiar?

@kazo0
Copy link
Contributor

kazo0 commented Apr 29, 2024

@marwalsch this behaviour is typically driven by:

<item name="android:windowTranslucentStatus">true</item>
<item name="android:windowTranslucentNavigation">true</item

In the styles.xml in the Android folder. Those usually shouldn't default to true in Uno apps. Would you be able to attach your reproduction apps as zips here? I can take a look and see what's causing this

Were these two apps just created from the Uno templates and nothing else was changed except the Uno version?

@kazo0
Copy link
Contributor

kazo0 commented Apr 29, 2024

Oh wait I just realized this is marked as iOS, sorry I thought those screenshots looked like an android device. Ok will investigate but would still be good to have those sample apps attached

@marwalsch
Copy link
Author

@kazo0 I just tried this on the Android simulator. Here status bar and dock always behave as in image 2 from above, at least in 5.1.104 and several earlier releases.

I will try to break this down in a repro.

@kazo0 kazo0 self-assigned this May 13, 2024
@kazo0
Copy link
Contributor

kazo0 commented May 14, 2024

@marwalsch does the page have any content in it behind the green areas?

@kazo0
Copy link
Contributor

kazo0 commented May 14, 2024

@marwalsch Also, if you would be able to post a repro project where this is happening on iOS, that would be super helpful! I Can't seem to get this to reproduce on my side. Is this happening on a physical iOS device or on the simulator as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

No branches or pull requests

3 participants