Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The .user file should not override the targetframeworks if the override is not present #16507

Closed
jeromelaban opened this issue Apr 29, 2024 · 1 comment · Fixed by #16661
Closed
Labels
area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools triage/untriaged Indicates an issue requires triaging or verification

Comments

@jeromelaban
Copy link
Member

Current behavior

If .user file contains an unknown target framework, inside VS the rewrite may be incorrectly reuse that TFM if it's not present in the TargetFrameworks list.

Expected behavior

Build continues to work properly even if the target frameworks list changes.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

5.2.95

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@jeromelaban jeromelaban added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk labels Apr 29, 2024
@agneszitte
Copy link
Contributor

(Related discussion: #16504)

@jeromelaban jeromelaban changed the title The .user file should be override the targetframeworks if the override is not present The .user file should not override the targetframeworks if the override is not present Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants