Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] The MessageDialog can be light dismissed #1950

Closed
2 of 10 tasks
BrianDT opened this issue Oct 25, 2019 · 1 comment · Fixed by #6654
Closed
2 of 10 tasks

[Android] The MessageDialog can be light dismissed #1950

BrianDT opened this issue Oct 25, 2019 · 1 comment · Fixed by #6654
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...)

Comments

@BrianDT
Copy link

BrianDT commented Oct 25, 2019

Either light dismissed should not happen or it should execute the cancel command.

Expected behavior

Light dismiss should not occur.

How to reproduce it (as minimally and precisely as possible)

A sample that reproduces the issue can be found here:
https://github.com/BrianDT/UnoDialogIssues

Nuget Package:

Package Version(s):
Uno.UI: 2.0.512-dev.3570

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )
@BrianDT BrianDT added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Oct 25, 2019
@jeromelaban jeromelaban added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform and removed triage/untriaged Indicates an issue requires triaging or verification labels Oct 25, 2019
@jeromelaban jeromelaban changed the title On Android the MessageDialog can be light dismissed [Android] The MessageDialog can be light dismissed Oct 25, 2019
@jeromelaban jeromelaban added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 25, 2019
@dr1rrb dr1rrb mentioned this issue Mar 4, 2020
Closed
8 tasks
@francoistanguay francoistanguay modified the milestone: 3.1 Aug 29, 2020
@agneszitte agneszitte added the project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...) label Sep 21, 2020
@jeromelaban jeromelaban added the difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. label Feb 15, 2021
@BrianDT
Copy link
Author

BrianDT commented Apr 19, 2021

Still an issue in version Uno.UI 3.6.6, sample updated.

@MartinZikmund MartinZikmund added difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers area/eu and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jun 1, 2021
@MartinZikmund MartinZikmund added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 10, 2021
This was referenced Aug 4, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Disable light-dismissing MessageDialog Youssef1313/uno
5 participants
@MartinZikmund @BrianDT @jeromelaban @agneszitte @francoistanguay