Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On WASM the MessageDialog display is incomplete #1953

Closed
2 of 10 tasks
BrianDT opened this issue Oct 25, 2019 · 3 comments
Closed
2 of 10 tasks

On WASM the MessageDialog display is incomplete #1953

BrianDT opened this issue Oct 25, 2019 · 3 comments
Labels
kind/bug Something isn't working platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform

Comments

@BrianDT
Copy link

BrianDT commented Oct 25, 2019

On WASM MessageDialog actions are not trigged and only one button is displayed.

Expected behavior

All buttons should be displayed and the actions should be triggered on button press

How to reproduce it (as minimally and precisely as possible)

A sample that reproduces the issue can be found here:
https://github.com/BrianDT/UnoDialogIssues

Nuget Package:
Uno.UI: 2.0.512-dev.3570

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )
@BrianDT BrianDT added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Oct 25, 2019
@jeromelaban jeromelaban added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform and removed triage/untriaged Indicates an issue requires triaging or verification labels Oct 25, 2019
@jeromelaban
Copy link
Member

Thank you for the report!

Could you paste a screenshot of what you seeing ?

@BrianDT
Copy link
Author

BrianDT commented Oct 28, 2019

Uno_Issue_1955

@jeromelaban
Copy link
Member

jeromelaban commented Oct 28, 2019 •
edited
Loading

Ah! Yes. This is a known issue that was not yet fixed. The current implementation uses the default javascript alert dialog, which does not provide the ability to add additional buttons. See #678

At the time, Uno did not support ContentDialog but it is now. MessageDialog could now be implemented using it.

I'll close this issue as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrianDT @jeromelaban