[Skia] Restore Runtime Tests

[jeromelaban]

Current behavior

After the introduction of Skia runtime tests, the following runtime tests are failing:

• ValidateLayoutRoundingForPixelDimensions
• CanReplaceSingleItem
• When_CloseLast_Then_FileDeleted
• Should_Close_Open_Popups
• When_TransformToVisual_WithMargin
• When_MinWidth_SmallerThan_AvailableSize (fix: Workaround a lifecycle bug to allow ContentControl to be measured properly when not in visual tree #14368)
• TestVariousArrangedPosition
• When_ProgressRing_Visible
• When_Calling_Select_With_Negative_Values
• When_Calling_Select_With_In_Range_Values
• When_Calling_Select_With_Out_Of_Range_Length
• When_Calling_Select_With_Out_Of_Range_Start
• When_Nested_In_Native_View

Those tests are now ignore in order to stabilize existing passing tests.

Expected behavior

The tests pass.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

3.11-dev

Affected platforms

Skia (GTK on Linux/macOS/Windows)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

[Youssef1313]

When_Calling_Select_With_Negative_Values this one is passing for me locally. The code for it is actually not platform-specific.

For other selection tests, Select in TextBoxViewExtension class seems to be missing EnsureWidget call. This was causing us to operate on a null _currentInputWidget and just returning without doing anything. BUT, even after adding the EnsureWidget call. The native APIs doesn't seem to be working. Will try to investigate further.

[Youssef1313]

ValidateLayoutRoundingForPixelDimensions is passing locally for me.

Should_Close_Open_Popups is failing due to RegisterOpenPopup being called twice for the same popup. It has an AddDistinct method, but to me the AddDistinct will never work since we're comparing a newly instantiated WeakReference, not the popup itself. I'm not sure if using WeakReferenceEqualityComparer is the correct fix here.

Anyway, instead of completely disable this test, let's turn the check into > 0 instead of == 1 (only on Skia), until it's properly fixed.

EDIT: Actually MessageDialog.ShowAsync isn't implemented in Skia. So even with this fix it will still not work. Let's link this test to #4810 instead?

[jeromelaban]

We can enable those back one we find the proper fixes, the point of the associated PR is to have regression validation.

For the ValidateLayoutRoundingForPixelDimensions is suspect this is related to DPI awareness.

[MartinZikmund]

@morning4coffe-dev maybe you could look into some of these

[mcNets]

In reference to CanReplaceSingleItem

I've checked Skia and WPF and both fails, but I can't find the same test for WinUI.

When repeater is set

uno/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/FlowLayoutCollectionChangeTests.cs

Line 279 in 52c6091

repeater = SetupRepeater(dataSource, ref scrollViewer);

It takes only three child elements so, why it should be 4?

uno/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/FlowLayoutCollectionChangeTests.cs

Line 300 in 52c6091

Verify.AreEqual(4, realized);

@jeromelaban is there a way to compare the UNO Windows.UI.Xaml.FrameworkElement with the MS version?

[Youssef1313]

I took a look at CanReplaceSingleItem. In FlowLayoutAlgorithm.Generate, there is this loop which is realizing elements:

				while (m_elementManager.IsIndexValidInData(currentIndex) &&
					(disableVirtualization || ShouldContinueFillingUpSpace(previousIndex, direction)))

For some reason, it only realizes three elements whereas in Windows it realizes four. I couldn't go further with this. 😕