Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gallery][iOS/Android/SkiaGtk] Commandbar- For 'Material Page' Close button is missing in light theme. #8996

Open
sakshi173 opened this issue Jun 8, 2022 · 4 comments
Open

[Gallery][iOS/Android/SkiaGtk] Commandbar- For 'Material Page' Close button is missing in light theme. #8996

sakshi173 opened this issue Jun 8, 2022 · 4 comments
Assignees
@Arieldelossantos
Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery

Comments

@sakshi173
Copy link

sakshi173 commented Jun 8, 2022 •
edited by Xiaoy312
Loading

Current behavior

Close button issue

still clickable, just the icon is not visible

Expected behavior

Close button

How to reproduce it (as minimally and precisely as possible)

  1. Open Uno Gallery APP
  2. Tap Burger Menu on the left top right.
  3. Click on the Light/Dark theme change toggle button.
  4. Notice that the app is displaying in the Light theme.
  5. Tap "CommandBar" from the "Component" list.
  6. Tap on the 'Show Sample' button.
  7. Observe that the Close button is missing on the top header.

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

No response

Affected platforms

Android

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@sakshi173 sakshi173 added kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform triage/untriaged Indicates an issue requires triaging or verification area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jun 8, 2022
@Xiaoy312 Xiaoy312 added the project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery label Jul 7, 2022
@sakshi173 sakshi173 changed the title [Gallery][Android] Commandbar- For 'Material Page' Close button is missing in light theme. [Gallery][iOS/Android] Commandbar- For 'Material Page' Close button is missing in light theme. Jul 27, 2022
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Dec 2, 2022
@sakshi173 sakshi173 changed the title [Gallery][iOS/Android] Commandbar- For 'Material Page' Close button is missing in light theme. [Gallery][iOS/Android/SkiaGtk] Commandbar- For 'Material Page' Close button is missing in light theme. Dec 28, 2022
@sakshi173
Copy link
Author

@jeromelaban ,This issue is still present, please look into it.

@Arieldelossantos Arieldelossantos self-assigned this May 19, 2023
This was referenced Jun 2, 2023
Closed
Closed
Merged
@Youssef1313
Copy link
Member

Youssef1313 commented Jun 26, 2023 •
edited
Loading

This might get fixed by #12691

@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 31, 2023
@agneszitte
Copy link
Contributor

@sakshi173 now that #12691 is merged, can you confirm if this is still happening on latest canary build please

@sakshi173
Copy link
Author

@agneszitte , I retested but this issue is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arieldelossantos Arieldelossantos

Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@MartinZikmund @Xiaoy312 @jeromelaban @agneszitte @Youssef1313 @Arieldelossantos @sakshi173