Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x:Bind uses DependencyObject.SetValue instead of the C# setter #9886

Open
jeromelaban opened this issue Sep 19, 2022 · 2 comments
Open

x:Bind uses DependencyObject.SetValue instead of the C# setter #9886

jeromelaban opened this issue Sep 19, 2022 · 2 comments
Assignees
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/xBind 🪢 Categorizes an issue or PR as relevant to x:Bind kind/tracking-only Categorizes an issue that is currently open for tracking purposes only. project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine

Comments

@jeromelaban
Copy link
Member

jeromelaban commented Sep 19, 2022

Originally posted by @mcNets in #9876

For performance reasons, to avoid type casting, the x:Bind engine in Uno is using explicit DependencyObject.SetValue when setting the target property value, where WinUI uses the C# property setter instead.

We may not change this behavior, unless this becomes problem, as performance is a more important concern at this time.

@jeromelaban jeromelaban added kind/enhancement New feature or request project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine area/performance 📈 Categorizes an issue or PR as relevant to performance labels Sep 19, 2022
@jeromelaban jeromelaban added the area/xBind 🪢 Categorizes an issue or PR as relevant to x:Bind label May 29, 2023
@MartinZikmund MartinZikmund changed the title x:Bind uses DependencyObject.SetValue instead of the C# setter x:Bind uses DependencyObject.SetValue instead of the C# setter Aug 16, 2023
@MartinZikmund MartinZikmund added kind/tracking-only Categorizes an issue that is currently open for tracking purposes only. and removed kind/enhancement New feature or request labels Aug 16, 2023
@christianfo
Copy link

This might warrant a spot on the list of common issues. I could not find it there. The problem with these small differences between WinUI3 and Uno is that any one of them taken separately is not a big deal, but together, they add up and make the process of moving an app to Uno more tedious than it could be in my opinion. A comprehensive list of known differences would go a long way to help the process.

@jeromelaban
Copy link
Member Author

jeromelaban commented Nov 22, 2023

This is fair. Those differences are for scattered around issues, though an issue marked as an epic would help around those differences, or maybe a tag, or directly in the common issues list as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance area/xBind 🪢 Categorizes an issue or PR as relevant to x:Bind kind/tracking-only Categorizes an issue that is currently open for tracking purposes only. project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine
Projects
None yet
Development

No branches or pull requests

4 participants